On 02/27/19 11:04, Michal Privoznik wrote: > The idea is that using this attribute users enable libvirt to > automagically select firmware image for their domain. For > instance: > > <os firmware='efi'> > <type arch='x86_64' machine='pc-q35-4.0'>hvm</type> > <loader secure='no'/> > </os> > > <os firmware='bios'> > <type arch='x86_64' machine='pc-q35-4.0'>hvm</type> > </os> > > (The automagic of selecting firmware image will be described in > later commits.) > > Accepted values are 'bios' and 'efi' to let libvirt select > corresponding type of firmware. > > I know it is a good sign to introduce xml2xml test case when > changing XML config parser but that will have to come later. > Firmware auto selection is not enabled for any driver just yet so > any xml2xml test would fail right away. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > docs/formatdomain.html.in | 22 +++++++++- > docs/schemas/domaincommon.rng | 8 ++++ > src/conf/domain_conf.c | 75 ++++++++++++++++++++++++++++------- > src/conf/domain_conf.h | 12 ++++++ > src/libvirt_private.syms | 2 + > 5 files changed, 103 insertions(+), 16 deletions(-) I prefer to leave the review of this patch to others; again because I'm unsure if this is the desired syntax in the domain XML. Thanks Laszlo -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
