ping? I also think that w/ Peter's addition of VIR_XPATH_NODE_AUTORESTORE even more changes could be done, but I'd leave those for either Peter to finish what he started or the mythical future someone else. Tks - John On 2/20/19 1:33 PM, John Ferlan wrote: > v1: https://www.redhat.com/archives/libvir-list/2019-February/msg01160.html > > Changes since v1: > > * Push patch 1 > > * Split patch 2 to follow code review guidance: > > * (Patch1) Pull out virDomainEmulatorPinDefParseXML changes to > use VIR_STEAL_PTR > * (Patch2) Use VIR_AUTOPTR(virBitmap) > * (Patch3) Handle a couple cases where goto's no longer necessary > > * Drop Patch 3 > > * Split Patch 4 to follow code review guidance: > > * (Patch4) Remove unused variables > * (Patch5) Just use VIR_AUTOFREE > * (Patch6) Handle the removal of goto logic that's no longer necessary > > > John Ferlan (6): > conf: Rework virDomainEmulatorPinDefParseXML > conf: Use VIR_AUTOPTR(virBitmap) in domain_conf > conf: Clean up some unnecessary goto paths > conf: Remove a few unused variables in domain_conf > conf: Use VIR_AUTOFREE in domain_conf > conf: Clean up some unnecessary goto paths > > src/conf/domain_conf.c | 1937 ++++++++++++++-------------------------- > 1 file changed, 676 insertions(+), 1261 deletions(-) > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list