On Tue, Feb 26, 2019 at 06:44:18PM -0500, Laine Stump wrote: > On 2/26/19 1:07 PM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > --- > > lib/Sys/Virt/TCK/DomainBuilder.pm | 10 ++ > > lib/Sys/Virt/TCK/NetworkBuilder.pm | 20 ++++ > > scripts/networks/400-guest-bandwidth.t | 147 +++++++++++++++++++++++++ > > > You forgot to add the test file to MANIFEST :-) > > > Other than that, > > > Reviewed-by: Laine Stump <laine@xxxxxxxxx> > > > (the test could be made more thorough by checking that the bandwidth had > actually been set (by checking the output of whatever appropriate tc > command, and maybe even by doing a netcat from host to guest and making sure > it stays below the limit), but this is a lot better than what we were > testing before!) Yes, I was wondering about checking tc in some way. This new script already found some nice bugs in my network refactor patches which proves its worth. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
