Re: [PATCH 1/5] cfg: Add VIR_AUTO(UNREF|CLEAN|STRINGLIST) to sc_requirere_attribute_cleanup_initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



d/'requirere'/
how about:
syntax-check: require intialization for new VIR_AUTO macros

On Tue, Feb 26, 2019 at 06:08:08PM +0100, Peter Krempa wrote:
The syntaxcheck should also check the new ones.

s/syntaxcheck/syntax-check/


Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
cfg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cfg.mk b/cfg.mk
index 7762422da7..f99b8ae631 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -1070,7 +1070,7 @@ sc_prohibit_backslash_alignment:
# Rule to ensure that variables declared using a cleanup macro are
# always initialized.
sc_require_attribute_cleanup_initialization:
-	@prohibit='VIR_AUTO((FREE|PTR)\(.+\)|CLOSE) *[^=]+;' \
+	@prohibit='VIR_AUTO((FREE|PTR|UNREF|CLEAN)\(.+\)|CLOSE|STRINGLIST) *[^=]+;' \

Note that VIR_AUTOSTRINGLIST is not merged yet.

	in_vc_files='\.[chx]$$' \
	halt='variable declared with a cleanup macro must be initialized' \
	  $(_sc_search_regexp)

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux