Re: [PATCH v4 01/20] snapshots: Avoid term 'checkpoint' for full system snapshot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/9/19 9:40 AM, John Ferlan wrote:
> 
> 
> On 2/6/19 2:17 PM, Eric Blake wrote:
>> Upcoming patches plan to introduce virDomainCheckpointPtr as a new
>> object for use in incremental backups, along with documentation on
>> how incremental backups differ from snapshots.  But first, we need
>> to rename any existing mention of a 'system checkpoint' to instead
>> be a 'full system snapshot', so that we aren't overloading
>> the term checkpoint.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>>
>> ---
>> v2: wording improvements based on review
>> ---
>>  include/libvirt/libvirt-domain-snapshot.h |  2 +-
>>  docs/formatsnapshot.html.in               | 31 +++++++++++------------
>>  src/conf/snapshot_conf.c                  |  4 +--
>>  src/libvirt-domain-snapshot.c             |  7 ++---
>>  src/qemu/qemu_driver.c                    | 12 ++++-----
>>  tools/virsh-snapshot.c                    |  2 +-
>>  tools/virsh.pod                           | 14 +++++-----
>>  7 files changed, 36 insertions(+), 36 deletions(-)
>>
> 
> Figured I'd start this and continue on Monday
> 
> In my "scan" of this I found it "interesting" that eventually as we get
> closer to the user docs there's an emphasis to know the difference
> between external and internal snapshots...
> 
> Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

I think I'll go ahead and push this one now, regardless of the work
remaining on the rest of the series, as it is a nice cleanup to have in
the release.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux