On 2/22/19 6:06 PM, John Snow wrote: > "Frozen" was a good description a long time ago, but it isn't adequate now. > Rename the frozen predicate to has_successor to make the semantics of the > predicate more clear to outside callers. > > In the process, remove some calls to frozen() that no longer semantically > make sense. For bdrv_enable_dirty_bitmap_locked and > bdrv_disable_dirty_bitmap_locked, it doesn't make sense to prohibit QEMU > internals from performing this action when we only wished to prohibit QMP > users from issuing these commands. All of the QMP API commands for bitmap > manipulation already check against user_locked() to prohibit these actions. > > Several other assertions really want to check that the bitmap isn't in-use > by another operation -- use the bitmap_user_locked function for this instead, > which presently also checks for has_successor. This leaves some redundant > checks of has_sucessor through different helpers that are addressed in successor (maintainer can fix, if we don't need v4) > forthcoming patches. > > Signed-off-by: John Snow <jsnow@xxxxxxxxxx> > --- > block/dirty-bitmap.c | 32 +++++++++++++++++--------------- > include/block/dirty-bitmap.h | 2 +- > migration/block-dirty-bitmap.c | 2 +- > 3 files changed, 19 insertions(+), 17 deletions(-) > Reviewed-by: Eric Blake <eblake@xxxxxxxxxx> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
