On 2/20/19 3:46 PM, Cole Robinson wrote: > On 2/13/19 3:31 AM, Andrea Bolognani wrote: >> On Fri, 2019-02-08 at 17:11 -0500, Cole Robinson wrote: >>> v2 libvirt patches: >>> https://www.redhat.com/archives/libvir-list/2019-January/msg00877.html >>> v1 libvirt patches: >>> https://www.redhat.com/archives/libvir-list/2019-January/msg00593.html >>> Previous incomplete RFC here: >>> https://www.redhat.com/archives/libvir-list/2019-January/msg00346.html >>> qemu patches, queued for qemu 4.0.0: >>> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg00923.html >>> Previous libvirt discussion around this: >>> https://www.redhat.com/archives/libvir-list/2018-August/msg01073.html >>> >>> Changes since v2: >>> * Some prep patches merged >>> * filesystem model dropped the -9p naming, now uses virtio-{non-}transitional >>> like other devices >>> * Now uses a single capability QEMU_CAPS_VIRTIO_PCI_NON_TRANSITIONAL >>> which is set whenever any of the -transitional or -non-transitional >>> devices are present. >>> * Add a formatdomain section 'Virtio transitional devices' and reference >>> it from each relevant device section >>> * if virtio-transitional specified, and qemu is too old but has the >>> disable_X options, convert it to explicit >>> disable-legacy=off,disable-modern=off >>> * Misc small changes pointed out in review >> > > Thanks for the reviews, I fixed all the issues you pointed out and > pushed the patches here: > > https://github.com/crobinso/libvirt/tree/virtio-v4 > > I'll wait to push until after 5.2.0 is out, so we have a longer window > to tweak things if eduardo's responses change anything, and to discuss > the controller type=scsi model=virtio patch I think you have pending... > I meant version 5.1.0 - Cole