On 2/14/19 4:29 PM, Eric Blake wrote: > Commit f609cb85 (0.9.5) introduced virDomainSnapshotGetXMLDesc()'s use > of @flags as a subset of virDomainXMLFlags, documenting that 2 of the > 3 flags defined at the time would never be valid. Later, commit > 28f8dfdc (1.0.0) introduced a new flag, VIR_DOMAIN_XML_MIGRATABLE, but > did not adjust the snapshot documentation to declare it as invalid. > However, since the flag is not accepted as valid by any of the > drivers (remote is just passthrough; esx and vbox don't support flags; > qemu, test, and vz only support VIR_DOMAIN_XML_SECURE), and it is > unlikely that the domain state saved off during a snapshot creation > needs to be migration-friendly (as the snapshot is not the source of > a migration), it is easier to just define an explicit set of supported > flags directly related to the snapshot API rather than trying to > borrow from domain API, and risking confusion if even more domain > flags are added later (in fact, I have an upcoming patch that plans to > add a new flag to virDomainGetXMLDesc that makes no sense for > snapshots). > > There is no API or ABI impact (since we purposefully used unsigned int > rather than an enum type in public API, and since the new flag name > carries the same value as the reused name). > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > include/libvirt/libvirt-domain-snapshot.h | 4 ++++ > src/libvirt-domain-snapshot.c | 9 ++++----- > src/qemu/qemu_driver.c | 2 +- > src/remote/remote_protocol.x | 2 +- > src/test/test_driver.c | 2 +- > src/vz/vz_driver.c | 2 +- > 6 files changed, 12 insertions(+), 9 deletions(-) > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John
