Re: [PATCH v2 2/5] qemu: Use correct domain xml flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2/14/19 4:29 PM, Eric Blake wrote:
> Although VIR_DOMAIN_DEF_FORMAT_INACTIVE and VIR_DOMAIN_XML_INACTIVE
> happen to have the same value (1<<1), they come from different enums;
> and it is nicer to reason about a 'flags' variable if all uses of
> that variable are compared against the same enum type.  Messed up in
> commit 06f75ff2 (3.8.0).
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux