On Tue, Feb 19, 2019 at 10:04:52AM +0100, Jiri Denemark wrote:
While qemuProcessQMPRun and virQEMUCapsInitQMPMonitor* functions called from virQEMUCapsInit ignore some errors, the caller of virQEMUCapsInit would report an error unless usedQMP is true anyway. And since usedQMP can only be true if the probing code really succeeded (i.e., no errors were ignored), we can just simplify the logic by not ignoring the errors in the first place.
Thank you.
Signed-off-by: Jiri Denemark <jdenemar@xxxxxxxxxx> --- Notes: Version 7: - this is a rewritten version of [PATCH 08/33] qemu_process: All ProcessQMP errors are fatal from version 6 src/qemu/qemu_capabilities.c | 17 +---------------- src/qemu/qemu_process.c | 27 +++++++++++---------------- 2 files changed, 12 insertions(+), 32 deletions(-)
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature