Re: [PATCH] virsh: fix snapshot list --parent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/14/19 7:48 AM, Ján Tomko wrote:
> The root snapshot does not have a parent.
> Use NULLSTR_EMPTY to pass an empty string instead of putting
> too few columns in the table.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1662849
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  tools/virsh-snapshot.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@xxxxxxxxxx>

> 
> diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
> index 90000ef1aa..6cadb2b0d6 100644
> --- a/tools/virsh-snapshot.c
> +++ b/tools/virsh-snapshot.c
> @@ -1608,7 +1608,8 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
>                   &time_info);
>  
>          if (parent) {
> -            if (vshTableRowAppend(table, snap_name, timestr, state, parent_snap,
> +            if (vshTableRowAppend(table, snap_name, timestr, state,
> +                                  NULLSTR_EMPTY(parent_snap),
>                                    NULL) < 0)
>                  goto cleanup;
>          } else {
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux