On Wed, Oct 21, 2009 at 07:15:24PM +0100, Daniel P. Berrange wrote:
> Introduce a number of new APIs to expose some boolean properties
> of objects, which cannot otherwise reliably determined, nor are
> aspects of the XML configuration.
[...]
> +/**
> + * virStoragePoolIsPersistent:
> + *
> + * Determine if the storagepool has a persistent configuration
space missing :-)
storage pool
> +/**
> + * virInterfaceIsActive:
description for @iface is missing here
> + *
> + * Determine if the interface is currently running
> + *
> + * Returns 1 if running, 0 if inactive, -1 on error
> + */
> +int virInterfaceIsActive(virInterfacePtr iface)
> +/**
> + * virConnectIsEncrypted:
here missing @conn
> + *
> + * Determine if the connection to the hypervisor is encrypted
> + *
> + * Returns 1 if encrypted, 0 if not encrypted, -1 on error
> + */
> +int virConnectIsEncrypted(virConnectPtr conn)
> +/**
> + * virConnectIsSecure:
idem
> + *
> + * Determine if the connection to the hypervisor is secure
> + *
> + * A connection will be classed as secure if it is either
> + * encrypted, or running over a channel which is not exposed
> + * to eavesdropping (eg a UNIX domain socket, or pipe)
> + *
> + * Returns 1 if secure, 0 if secure, -1 on error
> + */
> +int virConnectIsSecure(virConnectPtr conn)
[...]
>
> +LIBVIRT_0.7.4 {
0_7_3 as raised by Matthias
> + global:
> + virConnectIsEncrypted;
> + virConnectIsSecure;
> + virDomainIsActive;
> + virDomainIsPersistent;
> + virNetworkIsActive;
> + virNetworkIsPersistent;
> + virStoragePoolIsActive;
> + virStoragePoolIsPersistent;
> + virInterfaceIsActive;
> +} LIBVIRT_0.7.2;
> +
> # .... define new API here using predicted next version number ....
[...]
> static virNetworkDriver network_driver = {
> @@ -8470,6 +8474,8 @@ static virNetworkDriver network_driver = {
> .networkGetBridgeName = remoteNetworkGetBridgeName,
> .networkGetAutostart = remoteNetworkGetAutostart,
> .networkSetAutostart = remoteNetworkSetAutostart,
> + .networkIsActive = NULL,
> + .networkIsPersistent = NULL,
> };
>
> static virInterfaceDriver interface_driver = {
> @@ -8487,6 +8493,7 @@ static virInterfaceDriver interface_driver = {
> .interfaceUndefine = remoteInterfaceUndefine,
> .interfaceCreate = remoteInterfaceCreate,
> .interfaceDestroy = remoteInterfaceDestroy,
> + .interfaceIsActive = NULL, /* interfaceIsActive */
> };
>
> static virStorageDriver storage_driver = {
> @@ -8525,6 +8532,9 @@ static virStorageDriver storage_driver = {
> .volGetInfo = remoteStorageVolGetInfo,
> .volGetXMLDesc = remoteStorageVolDumpXML,
> .volGetPath = remoteStorageVolGetPath,
> +
> + .poolIsActive = NULL, /* poolIsActive */
> + .poolIsPersistent = NULL, /* poolIsEncrypted */
> };
I though we had switched back all driver tabs to old style
initialization, apparently not those :-)
ACK once the comments are updated as well as those pointed by Matthias
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list