$SUBJ: s/qemuL:/qemu:/ On 2/11/19 10:40 AM, Michal Privoznik wrote: > Introduced by d86c876a66e3. > > There is no real need to have "user-" prefix for chardev. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_command.c | 2 +- > tests/qemuxml2argvdata/channel-guestfwd.args | 2 +- > .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args | 4 ++-- > .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args | 4 ++-- > tests/qemuxml2argvdata/name-escape.args | 2 +- > 5 files changed, 7 insertions(+), 7 deletions(-) > At least it wasn't "ua-" ;-) Although I don't believe this patch is necessary. It's only made necessary because two patches from now qemuDomainDetachChrDevice wants to use tmpChr->info.alias instead of grabbing the alias that was used to generated the command line from qemuBuildChrDeviceStr out of the @devstr. Let me hold off on an R-by for this until you give feedback on my patch4 comments... John BTW: looks to me like af249ea46 originally implemented using id= string without the user- prefix. Eventually 7b2f8cdd7c removed id=, but then the above restores it; however, w/ user- prefix.
