On Fri, 2019-02-08 at 17:12 -0500, Cole Robinson wrote: > Add <controller type='scsi' model handling for virtio transitional > devices. Ex: > > <controller type='scsi' model='virtio-transitional'/> > > * "virtio-transitional" maps to qemu "virtio-scsi-pci-transitional" > * "virtio-non-transitional" maps to qemu "virtio-scsi-non-transitional" > > The naming here doesn't match the pre-existing model=virtio-scsi. > The prescence of '-scsi' there seems kind of redundant as we have > type='scsi' already, so I decided to follow the pattern of other > patches and use virtio-transitional etc. > > Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx> > --- > docs/formatdomain.html.in | 7 +++++-- > docs/schemas/domaincommon.rng | 2 ++ > src/conf/domain_conf.c | 14 ++++++++----- > src/conf/domain_conf.h | 2 ++ > src/qemu/qemu_command.c | 5 +++++ > src/qemu/qemu_domain.c | 8 +++++++- > src/qemu/qemu_domain_address.c | 3 +++ > src/vbox/vbox_common.c | 2 ++ > src/vmx/vmx.c | 5 ++++- > .../virtio-non-transitional.x86_64-3.1.0.args | 15 ++++++++------ > ...virtio-non-transitional.x86_64-latest.args | 14 +++++++------ > .../virtio-non-transitional.xml | 1 + > .../virtio-transitional.x86_64-3.1.0.args | 14 +++++++------ > .../virtio-transitional.x86_64-latest.args | 13 ++++++------ > .../qemuxml2argvdata/virtio-transitional.xml | 1 + > .../virtio-non-transitional.xml | 20 +++++++++++++------ > .../virtio-transitional.xml | 15 ++++++++------ > tests/qemuxml2xmltest.c | 6 ++++-- > 18 files changed, 100 insertions(+), 47 deletions(-) Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization