On Fri, 2019-02-08 at 17:12 -0500, Cole Robinson wrote: [...] > @@ -977,7 +977,18 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDefPtr dev, > break; > > case VIR_DOMAIN_DEVICE_VSOCK: > - return virtioFlags; > + switch ((virDomainVsockModel) dev->data.vsock->model) { > + case VIR_DOMAIN_VSOCK_MODEL_VIRTIO: > + case VIR_DOMAIN_VSOCK_MODEL_VIRTIO_NON_TRANSITIONAL: > + return virtioFlags; > + case VIR_DOMAIN_VSOCK_MODEL_VIRTIO_TRANSITIONAL: > + return pciFlags; Same nit as in 8/17. Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization