On 2/11/19 5:55 PM, Ján Tomko wrote:
On Fri, Feb 08, 2019 at 12:23:28PM +0100, Michal Privoznik wrote:
The wireshark-2.4.0 is almost 2 years old now. Assuming anybody
While 2 years is not that much given our support page:
https://libvirt.org/platforms.html
the wireshark plugin was always an exception to those
interested in running latest libvirt doesn't run old wireshark,
it is safe to do this. It also simplifies the code.
Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
libvirt.spec.in | 8 ++----
m4/virt-wireshark.m4 | 4 +--
tools/wireshark/src/packet-libvirt.c | 39 ----------------------------
tools/wireshark/src/plugin.c | 14 +++-------
4 files changed, 7 insertions(+), 58 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 13f41bb4a5..9beffba203 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -166,11 +166,7 @@
# Enable wireshark plugins for all distros shipping libvirt 1.2.2 or
newer
%if 0%{?fedora}
%define with_wireshark 0%{!?_without_wireshark:1}
-%endif
-%if 0%{?fedora} || 0%{?rhel} > 7
This gets rid of the rhel > 7 condition.
If it works on latest Fedora, shouldn't it work on RHEL 8 too?
We're not building wireshark plugin on any RHEL. This is merely dropping
a specfile variable that was passed to configure only on Fedora not RHEL.
Michal
