[PATCH] virsh: fix return value in storage vol name completor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The function must return a pointer, not a boolean. Fortunately 'false'
is equivalent to 'NULL' so this bug no had ill effect previously.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
 tools/virsh-completer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c
index e62226fc13..7c68e2e832 100644
--- a/tools/virsh-completer.c
+++ b/tools/virsh-completer.c
@@ -287,7 +287,7 @@ virshStorageVolNameCompleter(vshControl *ctl,
         return NULL;
 
     if (!(pool = virshCommandOptPool(ctl, cmd, "pool", NULL)))
-        return false;
+        return NULL;
 
     if ((nvols = virStoragePoolListAllVolumes(pool, &vols, flags)) < 0)
         goto error;
-- 
2.20.1


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux