Re: [PATCH v2 14/32] util: Fix virStorageBackendSCSINewLun error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 08, 2019 at 01:37:08PM -0500, John Ferlan wrote:
> Commit a523770c3 added @retval return processing for
> virStorageBackendUpdateVolInfo in order to allow a -2
> to be return; however, upon successful completion
> @retval = 0 and if either the virStorageBackendSCSISerial
> or the virStoragePoolObjAddVol failed, the method would
> return 0, but not add the @vol to the pool. So let's
> just reset retval = -1 and continue processing.
>
> Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx>
> ---
Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux