On Mon, Feb 11, 2019 at 06:10:38AM -0500, Laine Stump wrote: > On Mon, Feb 11, 2019, 5:47 AM Daniel P. Berrangé <berrange@xxxxxxxxxx> > wrote: > > > On Thu, Feb 07, 2019 at 10:08:28PM -0500, Laine Stump wrote: > > > RHEL8 has dropped support for qcow1 format images, so skip the tests > > > related to creating/cloning qcow1 images (based on the output of > > > qemu-img -help). > > > > > > Signed-off-by: Laine Stump <laine@xxxxxxxxx> > > > --- > > > scripts/storage/100-create-vol-dir.t | 22 ++++++++----- > > > scripts/storage/200-clone-vol-dir.t | 48 ++++++++++++++++------------ > > > 2 files changed, 41 insertions(+), 29 deletions(-) > > > > Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > > > > > This is an example where libvirt storage pool capabilities would be > > useful. > > > > Yeah, or maybe listing the supported types in the device capabilities for > the disks. I had meant to point that out but forgot. We would need both, because QEMU has a setup where qemu-img can support a disk format while qemu-system-XXX will not support it. This is so that we can limit what is usable at runtime, but still have qemu-img for data liberation from old format images. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
