Re: [PATCH 0/9] rpc: make client streams multi-thread safer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/7/19 1:58 PM, Nikolay Shirokovskiy wrote:
Nikolay Shirokovskiy (9):
   rpc: fix race on stream abort/finish and server side abort
   rpc: use single function to send stream messages
   rpc: remove unused virNetClientSendNoReply
   rpc: fix propagation of errors from server
   rpc: add mising locking in virNetClientStreamRecvHole
   rpc: client: incapsulate error checks
   rpc: client: don't set incomingEOF on errors
   rpc: client stream: dispose private data on stream dispose
   rpc: client: stream: fix multi thread abort/finish

  src/datatypes.c              |   2 +
  src/datatypes.h              |   1 +
  src/libvirt_remote.syms      |   6 +-
  src/remote/remote_driver.c   |  27 ++------
  src/rpc/gendispatch.pl       |   3 +-
  src/rpc/virnetclient.c       | 146 ++++++++++++++++++++++---------------------
  src/rpc/virnetclient.h       |   6 +-
  src/rpc/virnetclientstream.c | 110 ++++++++++++++++++++++++--------
  src/rpc/virnetclientstream.h |  17 ++++-
  9 files changed, 188 insertions(+), 130 deletions(-)


ACK series. I'm fixing all the small nits I've found and pushing.

I've also done some testing and nothing broke :-)

Michal


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux