Re: [PATCH v2 25/32] tests: qemuxml2argv: Add CDROM disks for all untested buses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 04, 2019 at 04:46:58PM +0100, Peter Krempa wrote:
Add full and empty cdroms on 'usb', 'virtio', and 'sd' bus to have test

Feels odd to add 'virtio' here if you remove it in the next patch.

coverage. Note that this does not guarantee that qemu will accept them.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
.../disk-cdrom-bus-other.x86_64-latest.args   | 45 +++++++++++++
.../qemuxml2argvdata/disk-cdrom-bus-other.xml | 58 +++++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
.../disk-cdrom-bus-other.xml                  | 64 +++++++++++++++++++
tests/qemuxml2xmltest.c                       |  1 +
5 files changed, 169 insertions(+)
create mode 100644 tests/qemuxml2argvdata/disk-cdrom-bus-other.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/disk-cdrom-bus-other.xml
create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-bus-other.xml


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux