On Tue, Jan 29, 2019 at 09:56:46AM +0100, Michal Privoznik wrote: > If a domain has a disk that is type='network' we require specific > cache mode to allow migration with it (either 'directsync' or > 'none'). This doesn't make much sense since network disks are > supposed to be safe to migrate by default. > > At the same time, we should be checking for the actual source > type, not apparent type set in the domain XML. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > > v2 of: > > https://www.redhat.com/archives/libvir-list/2019-January/msg01070.html > > diff to v1: > - Allow just every network disk > - Check for actual disk type not the apparent one > > src/qemu/qemu_migration.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx> -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
