On Thu, 2019-01-31 at 17:32 +0100, Ján Tomko wrote:
> On Thu, Jan 31, 2019 at 03:34:20PM +0100, Andrea Bolognani wrote:
> > +++ b/tests/qemuxml2argvtest.c
> > @@ -3072,6 +3072,8 @@ mymain(void)
> >
> > DO_TEST("riscv64-virt",
> > QEMU_CAPS_DEVICE_VIRTIO_MMIO);
> > + DO_TEST("riscv64-virt-pci",
> > + QEMU_CAPS_OBJECT_GPEX);
>
> Consider giving DO_TEST_CAPS_ARCH_LATEST a chance, for more faithful
> viewer experience.
I would have used it, but that would have resulted in the
qemuxml2xml version being different because the macro is not
available in that test program.
Cole has taken a stab at implementing it there too a couple of
weeks ago, but ultimately shelved the attempt to avoid getting the
rest of the (non-)transitional VirtIO work blocked on it. Since I
have a few more or less related gripes about the test suite, I might
end up picking up where he left and address those as well.
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
