Re: [PATCH 6/6] hyperv: use "is None" not "== None" for PEP-8 compliance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 1/30/19 12:40 PM, Daniel P. Berrangé wrote:
> PEP 8 says:
> 
>     "Comparisons to singletons like None should always be done
>      with 'is' or 'is not', never the equality operators."
> 
> There are potentially semantics differences, though in the case of this
> libvirt code its merely a style change:
> 
>   http://jaredgrubb.blogspot.com/2009/04/python-is-none-vs-none.html
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  src/hyperv/hyperv_wmi_generator.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux