Re: [PATCH 05/11] qemu: security: Add 'backingChain' flag to qemuSecurity[Set|Restore]ImageLabel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 28, 2019 at 09:27:51 -0500, John Ferlan wrote:
> 
> 
> On 1/23/19 11:11 AM, Peter Krempa wrote:
> > Allow callers use the new flag.
> > 
> > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> > ---
> >  src/qemu/qemu_domain.c   |  4 ++--
> >  src/qemu/qemu_security.c | 10 ++++++----
> >  src/qemu/qemu_security.h |  6 ++++--
> >  3 files changed, 12 insertions(+), 8 deletions(-)
> > 
> 
> Assuming previous comment/adjustment request to use int instead of
> flag.... The "false"'s change to 0 and 'bool backingChain' to unsigned
> int flags...

Passing in the flags of the security driver at this level would be weird.
At this point I'll keep the flag in the function header and convert it
to the appropriate flags.

I don't really see a point in adding yet another set of flags for the
qemu_security stuff.

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux