On Tue, Jan 29, 2019 at 01:22:00PM -0500, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1584663 > > Modify the command generation to add some default options to the > fs/netfs storage pools based on the OS type. For Linux, it'll be > the "nodev, nosuid, noexec". For FreeBSD, it'll be "nosuid, noexec". > For others, just leave the options alone. > > Modify the storagepoolxml2argvtest to handle the fact that the > same input XML could generate different output XML based on whether > Linux, FreeBSD, or other was being built. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > src/storage/storage_util.c | 36 ++++++++++++-- > .../pool-fs-freebsd.argv | 1 + > .../pool-fs-linux.argv | 1 + > .../pool-netfs-auto-freebsd.argv | 1 + > .../pool-netfs-auto-linux.argv | 1 + > .../pool-netfs-cifs-freebsd.argv | 1 + > .../pool-netfs-cifs-linux.argv | 1 + > .../pool-netfs-freebsd.argv | 1 + > .../pool-netfs-gluster-freebsd.argv | 2 + > .../pool-netfs-gluster-linux.argv | 2 + > .../pool-netfs-linux.argv | 1 + > tests/storagepoolxml2argvtest.c | 48 +++++++++++++++---- > 12 files changed, 84 insertions(+), 12 deletions(-) > create mode 100644 tests/storagepoolxml2argvdata/pool-fs-freebsd.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-fs-linux.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-auto-freebsd.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-auto-linux.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-cifs-freebsd.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-cifs-linux.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-freebsd.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-gluster-freebsd.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-gluster-linux.argv > create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-linux.argv Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
