On 01/17/2019 01:00 PM, John Ferlan wrote: > Found that it was missing in formatstorage and had a few typos > in the storage driver page. > > Signed-off-by: John Ferlan <jferlan@xxxxxxxxxx> > --- > noted while working on other stuff... > Also although <initiator> is supported by the "iscsi" pool as well, it's > not something ever documented since commit 6aabcb5bd (0.7.5). I could add > a note that it's optional to use with the "iscsi" pool if desired. > > docs/formatstorage.html.in | 20 ++++++++++++++++---- > docs/storage.html.in | 8 ++++---- > 2 files changed, 20 insertions(+), 8 deletions(-) > > diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in > index b6bf3edbd2..979e170c08 100644 > --- a/docs/formatstorage.html.in > +++ b/docs/formatstorage.html.in > @@ -18,7 +18,9 @@ > The top level tag for a storage pool document is 'pool'. It has > a single attribute <code>type</code>, which is one of <code>dir</code>, > <code>fs</code>, <code>netfs</code>, <code>disk</code>, > - <code>iscsi</code>, <code>logical</code>, <code>scsi</code> > + <code>iscsi</code>, > + <code>iscsi-direct</code>(<span class="since">since 4.7.0</span>), > + <code>logical</code>, <code>scsi</code> > (all <span class="since">since 0.4.1</span>), <code>mpath</code> Notice here the annotation says 'all since 0.4.1' which doesn't jive with the iscsi-direct placement. Could just append it to the list which seems to be the pattern. With that issue fixed: Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> Thanks, Cole -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
