Missing semicolon at the end of macros can confuse some analyzers (like cppcheck <filename>), and we have a mix of semicolon and non-semicolon usage through the code. Let's standardize on using a semicolon for VIR_LOG_INIT calls. Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx> --- src/conf/capabilities.c | 2 +- src/qemu/qemu_extdevice.c | 2 +- src/qemu/qemu_tpm.c | 2 +- src/util/virfilecache.c | 2 +- src/util/virresctrl.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/conf/capabilities.c b/src/conf/capabilities.c index fffae23b28..c3ccf1a18b 100644 --- a/src/conf/capabilities.c +++ b/src/conf/capabilities.c @@ -45,7 +45,7 @@ #define SYSFS_SYSTEM_PATH "/sys/devices/system" -VIR_LOG_INIT("conf.capabilities") +VIR_LOG_INIT("conf.capabilities"); VIR_ENUM_DECL(virCapsHostPMTarget); VIR_ENUM_IMPL(virCapsHostPMTarget, VIR_NODE_SUSPEND_TARGET_LAST, diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c index 5775563508..a21caefaba 100644 --- a/src/qemu/qemu_extdevice.c +++ b/src/qemu/qemu_extdevice.c @@ -33,7 +33,7 @@ #define VIR_FROM_THIS VIR_FROM_QEMU -VIR_LOG_INIT("qemu.qemu_extdevice") +VIR_LOG_INIT("qemu.qemu_extdevice"); int qemuExtDeviceLogCommand(qemuDomainLogContextPtr logCtxt, diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index 15b6ab8870..835a9caf46 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -44,7 +44,7 @@ #define VIR_FROM_THIS VIR_FROM_NONE -VIR_LOG_INIT("qemu.tpm") +VIR_LOG_INIT("qemu.tpm"); /* * executables for the swtpm; to be found on the host diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c index 15c0d99fd9..eb7dbd97cc 100644 --- a/src/util/virfilecache.c +++ b/src/util/virfilecache.c @@ -41,7 +41,7 @@ #define VIR_FROM_THIS VIR_FROM_NONE -VIR_LOG_INIT("util.filecache") +VIR_LOG_INIT("util.filecache"); struct _virFileCache { diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 626a5cdc21..a9eae5192a 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -33,7 +33,7 @@ #define VIR_FROM_THIS VIR_FROM_RESCTRL -VIR_LOG_INIT("util.virresctrl") +VIR_LOG_INIT("util.virresctrl"); /* Resctrl is short for Resource Control. It might be implemented for various -- 2.20.1 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list