Re: [PATCH] qemu: improve compile-time check of qemuBlockjobState mapping

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 23, 2019 at 13:45:07 -0600, Eric Blake wrote:
> Asserting the value we set four lines earlier in qemuBlockjobState
> doesn't buy us any safety (if the public header adds a value, we end
> up skipping that value without the compiler warning us of our gap);
> what we really want is to assert that the value auto-assigned by the
> compiler matches the actual last value in the public headers (as was
> done below for qemuBlockJobType).  Add useful comments while at it.
> 
> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
> ---

ACK

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux