Thanx for review, John! Let's wait for finishing -blockdev works indeed. Nikolay On 10.01.2019 15:15, Nikolay Shirokovskiy wrote: > As this patch series only works with -blockdev configurations it is better to > be pushed only after -blockdev is supported. Then 'news' and 'xml' patch need > to be updated to have correct libvirt version. > > Diff from v2 [1]: > ================= > - move caps patch to top > - add news patch > - add _CAPPED to capabilitity name to distinguish from > correspondent qemu capabilitiy > - better option explanation in formatdomain.html > - misc tests/english fixes as suggested > > We have come to agreement with John in mailing list to support QEMU versions > which do not let use INT64_MAX as "maximum" value. But this will require > changing qemuBlockStorageSourceGetFormatQcow2Props and a lot of other functions > signature (which was not noticed during conversation). Thus I don't add such > a functionality. Anyway the patch requires -blockdev from QEMU so we could only > support single QEMU 3.0 version. > > [1] https://www.redhat.com/archives/libvir-list/2018-November/msg00313.html > > Nikolay Shirokovskiy (5): > qemu: caps: add QEMU_CAPS_QCOW2_L2_CACHE_SIZE_CAPPED > xml: add disk driver metadata_cache_size option > qemu: support metadata-cache-size for blockdev > news: add notice for new metadata cache size policy option > DO NOT APPLY: add xml2argv test for metadata_cache_size > > docs/formatdomain.html.in | 11 ++++++ > docs/news.xml | 11 ++++++ > docs/schemas/domaincommon.rng | 11 ++++++ > src/conf/domain_conf.c | 17 +++++++++ > src/conf/domain_conf.h | 9 +++++ > src/qemu/qemu_block.c | 5 ++- > src/qemu/qemu_capabilities.c | 5 +++ > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 23 ++++++++++++ > src/qemu/qemu_domain.c | 2 ++ > src/util/virstoragefile.c | 1 + > src/util/virstoragefile.h | 1 + > .../qemuxml2argvdata/disk-metadata_cache_size.args | 39 ++++++++++++++++++++ > .../qemuxml2argvdata/disk-metadata_cache_size.xml | 35 ++++++++++++++++++ > tests/qemuxml2argvtest.c | 2 ++ > .../disk-metadata_cache_size.xml | 41 ++++++++++++++++++++++ > tests/qemuxml2xmltest.c | 2 ++ > 17 files changed, 215 insertions(+), 1 deletion(-) > create mode 100644 tests/qemuxml2argvdata/disk-metadata_cache_size.args > create mode 100644 tests/qemuxml2argvdata/disk-metadata_cache_size.xml > create mode 100644 tests/qemuxml2xmloutdata/disk-metadata_cache_size.xml > -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
