Re: [PATCH 2/3] maint: Prefer AM_CPPFLAGS over INCLUDES

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/7/19 5:19 AM, Ján Tomko wrote:
> On Fri, Jan 04, 2019 at 02:12:19PM -0600, Eric Blake wrote:
>> Our use of INCLUDES in Makefile.am hearkens back to when we had to
>> cater to automake 1.9.6 (thanks, RHEL 5) which lacked AM_CPPFLAGS.
>> Modern Automake flags a warning that INCLUDES is deprecated, and
>> now that we mandate RHEL 7 or better (see commit c1bc9c66), we no
>> longer have to cater to the old spelling.
>>
>> Signed-off-by: Eric Blake <eblake@xxxxxxxxxx>
>> ---
>> examples/Makefile.am | 3 ++-
>> src/Makefile.am      | 2 +-
>> tests/Makefile.am    | 4 ++--
>> tools/Makefile.am    | 2 +-
>> 4 files changed, 6 insertions(+), 5 deletions(-)
>>
> 
> Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

I've pushed the first two while revisiting the third for a v2.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux