Re: [PATCH v5 02/36] qemu_process: Use qemuProcessQmp prefix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 02, 2018 at 23:09:56 -0600, Chris Venteicher wrote:
> s/virQEMUCapsInitQMPCommand/qemuProcessQmp/

Please, use qemuProcessQMP prefix as suggested in my previous review.
There are several reasons for this:
    - QMP is not a word, it's the abbreviation for QEMU Monitor Protocol
    - we use QMP consistently in our code, we don't spell it as Qmp
      anywhere
    - Qmp is very ugly (might be subjective, though)

With s/Qmp/QMP/g

Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux