Re: [jenkins-ci PATCH] guests: Add json-glib dependency for osinfo-db-tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-12-19 at 14:30 +0100, Fabiano Fidêncio wrote:
[...]
> diff --git a/guests/vars/projects/osinfo-db-tools+mingw32.yml b/guests/vars/projects/osinfo-db-tools+mingw32.yml
> index b133331..647bea2 100644
> --- a/guests/vars/projects/osinfo-db-tools+mingw32.yml
> +++ b/guests/vars/projects/osinfo-db-tools+mingw32.yml
> @@ -4,3 +4,4 @@ packages:
>    - mingw32-libxml2
>    - mingw32-libxslt
>    - mingw32-libarchive
> +  - mingw32-json-glib
> diff --git a/guests/vars/projects/osinfo-db-tools+mingw64.yml b/guests/vars/projects/osinfo-db-tools+mingw64.yml
> index 049418c..415644a 100644
> --- a/guests/vars/projects/osinfo-db-tools+mingw64.yml
> +++ b/guests/vars/projects/osinfo-db-tools+mingw64.yml
> @@ -4,3 +4,4 @@ packages:
>    - mingw64-libxml2
>    - mingw64-libxslt
>    - mingw64-libarchive
> +  - mingw64-json-glib
> diff --git a/guests/vars/projects/osinfo-db-tools.yml b/guests/vars/projects/osinfo-db-tools.yml
> index 54d8006..2c533a3 100644
> --- a/guests/vars/projects/osinfo-db-tools.yml
> +++ b/guests/vars/projects/osinfo-db-tools.yml
> @@ -6,3 +6,4 @@ packages:
>    - libarchive
>    - libxml2
>    - libxslt
> +  - json-glib

The lists above are supposed to be alphabetically sorted, which
after your patch they no longer are. I'll fix that before pushing.

Other than that, the patch looks good and my testing confirms it
works fine, so

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

I'll push and apply the changes shortly.

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux