On Mon, Dec 17, 2018 at 02:34:30PM +0100, Michal Privoznik wrote:
> The driver is unmaintained, untested and severely broken for
> quite some time now. Since nobody even reported any issue with it
> let us drop it.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>
> diff to v2:
> - Add 'Obsoletes' line into the spec file as suggested by Dan.
> @@ -231,9 +229,8 @@ Requires: libvirt-daemon-driver-lxc = %{version}-%{release}
> %if %{with_qemu}
> Requires: libvirt-daemon-driver-qemu = %{version}-%{release}
> %endif
> -%if %{with_uml}
> -Requires: libvirt-daemon-driver-uml = %{version}-%{release}
> -%endif
> +# We had UML driver, but we've removed it.
> +Obsoletes: libvirt-daemon-driver-uml <= 5.0.0
Oh, we actually had 2 sub-RPMs so we'll need Obsoletes for each of
them.
> -%if %{with_uml}
> -%package daemon-driver-uml
[snip]
> -%if %{with_uml}
> -%package daemon-uml
No need to re-post a v4, assuming you just add the 2nd Obsoletes in the
obvious way:
Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
