On Fri, Dec 14, 2018 at 09:04:03PM +0100, Michal Privoznik wrote:
> The driver is unmaintained, untested and severely broken for
> quite some time now. Since nobody even reported any issue with it
> let us drop it.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
[snip]
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 71cd45c603..09472dcadc 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -20,7 +20,6 @@
> # The hypervisor drivers that run in libvirtd
> %define with_qemu 0%{!?_without_qemu:1}
> %define with_lxc 0%{!?_without_lxc:1}
> -%define with_uml 0%{!?_without_uml:1}
> %define with_libxl 0%{!?_without_libxl:1}
> %define with_vbox 0%{!?_without_vbox:1}
>
> @@ -111,13 +110,12 @@
> %endif
>
>
> -# RHEL doesn't ship OpenVZ, VBox, UML, PowerHypervisor,
> +# RHEL doesn't ship OpenVZ, VBox, PowerHypervisor,
> # VMware, libxenserver (xenapi), libxenlight (Xen 4.1 and newer),
> # or HyperV.
> %if 0%{?rhel}
> %define with_openvz 0
> %define with_vbox 0
> - %define with_uml 0
> %define with_phyp 0
> %define with_vmware 0
> %define with_xenapi 0
> @@ -178,7 +176,7 @@
> %endif
>
>
> -%if %{with_qemu} || %{with_lxc} || %{with_uml}
> +%if %{with_qemu} || %{with_lxc}
> # numad is used to manage the CPU and memory placement dynamically,
> # it's not available on many non-x86 architectures.
> %ifnarch s390 s390x %{arm} riscv64
> @@ -231,9 +229,6 @@ Requires: libvirt-daemon-driver-lxc = %{version}-%{release}
> %if %{with_qemu}
> Requires: libvirt-daemon-driver-qemu = %{version}-%{release}
> %endif
> -%if %{with_uml}
> -Requires: libvirt-daemon-driver-uml = %{version}-%{release}
> -%endif
> %if %{with_vbox}
> Requires: libvirt-daemon-driver-vbox = %{version}-%{release}
> %endif
Because the main "libvirt" RPM depended on "libvirt-daemon-driver-uml",
there will be existing users with that sub-RPM installed, even if they
were never using it.
Deleting the sub-RPM thus breaks the upgrade path, because RPM will
not see any newer "libvirt-daemon-driver-uml" sub-RPM to upgrade to.
It is thus required to add an
Obsoletes: libvirt-daemon-driver-uml <= 5.0.0
to the main libvirt RPM.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
