On Fri, Dec 14, 2018 at 12:08:55PM +0100, Erik Skultety wrote: > On Fri, Dec 14, 2018 at 10:11:55AM +0000, Daniel P. Berrangé wrote: > > On Fri, Dec 14, 2018 at 10:18:39AM +0100, Erik Skultety wrote: > > > For some reason, xdr_free uses char * instead of void * for its 2nd > > > argument which is passed to a custom free routine. Commit > > > dc54b3ec missed this detail which made the build fail on a number of > > > platforms. Fix it by explicitly casting the object pointer to char * > > > just like we do in other places throughout the code base. > > > > Which platforms did you see this on ? > > > > On Linux libtirpc declares it correctly > > > > extern void xdr_free(xdrproc_t, void *); > > Oh, then it's just the man-pages package on Fedora 29 which still reports the > wrong signature. Anyhow, CI reported the issue on Debian 8-9 and Centos7. Oh this is a difference with the original in-glibc impl which does indeed use char *. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
