On 12/13/18 6:02 AM, Nikolay Shirokovskiy wrote: > Every time we call all domain stats for inactive domain with > unavailable storage source we get error message in logs [1]. It's a bit noisy. > While it's arguable whether we need such message or not for mandatory > disks we would like not to see messages for optional disks. Let's > filter at least for cases of local files. Fixing other cases would > require passing flag down the stack to .backendInit of storage > which is ugly. > > Stats for active domain are fine because we either drop disks > with unavailable sources or clean source which is handled > by virStorageSourceIsEmpty in qemuDomainGetStatsOneBlockFallback. > > We have these logs for successful stats since 25aa7035d (version 1.2.15) > which in turn fixes 596a13713 (version 1.2.12 )which added substantial > stats for offline disks. > > [1] error message example: > qemuOpenFileAs:3324 : Failed to open file '/path/to/optional/disk': No such file or directory > > Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@xxxxxxxxxxxxx> > --- > src/qemu/qemu_domain.c | 9 +++++++++ > src/qemu/qemu_domain.h | 3 +++ > src/qemu/qemu_driver.c | 14 ++++++++++++++ > 3 files changed, 26 insertions(+) > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
