On 12/7/18 6:27 PM, John Ferlan wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1624336 > > Details are in patch2, but essentially the issue is the check > for whether cold/hot plug of memory is supported occurs during > qemuDomainDefValidateMemoryHotplug; however, that is called > after virDomainDefCompatibleDevice, but is not called during > the qemuDomainAttachDeviceConfig processing. > > Another solution would be to modify virDomainDefCompatibleDevice > to add a "if (def->mem.max_memory > 0 &&" check before the check > for whether the size fits and virDomainDefHasMemoryHotplug could > be called from qemuDomainAttachDeviceConfig, but that seems a bit > strange. The additional call is to avoid the equally strange message > that would appear "no free memory device slot available" because > nmems == mem.memory_slots == 0. If this solution is preferred I'm > fine with that, but figured I needed to start somewhere. > > John Ferlan (2): > conf: Add the size of failed max_memory in error > conf: Add check/error for domain supports cold/hotplug > > src/conf/domain_conf.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > ACK Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
