Matthias Bolte wrote: > 2009/10/12 Cole Robinson <crobinso@xxxxxxxxxx>: >> All schema tests have identical functionality, so avoid the duplication. >> >> Signed-off-by: Cole Robinson <crobinso@xxxxxxxxxx> >> --- >>  tests/Makefile.am      |   1 + >>  tests/capabilityschematest  |  34 ++++------------------------------ >>  tests/domainschematest    |  33 ++++----------------------------- >>  tests/interfaceschematest  |  31 +++---------------------------- >>  tests/networkschematest   |  30 +++--------------------------- >>  tests/nodedevschematest   |  31 +++---------------------------- >>  tests/schematestutils.sh   |  39 +++++++++++++++++++++++++++++++++++++++ >>  tests/storagepoolschematest |  31 +++---------------------------- >>  tests/storagevolschematest  |  30 +++--------------------------- >>  9 files changed, 63 insertions(+), 197 deletions(-) >>  create mode 100644 tests/schematestutils.sh > > Your patch adds some bashisms. This prevents make check from running > successfully on Debian/Ubuntu, because their default shell is dash and > not bash. > > The attached patch removes this bashisms. > > Matthias > Ah, I meant to check for that, I've made the same mistake in the past. ACK to the patch. Thanks, Cole -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list