On Tue, 2018-11-27 at 15:28 +0000, Daniel P. Berrangé wrote: > On Mon, Nov 26, 2018 at 01:21:32PM +0100, Andrea Bolognani wrote: > > Commit 26cfb1a3cd39 introduced a list of preferred machine types, > > which are meant to reflect QEMU's per-architecture historical > > defaults and shield libvirt users from any changes in that area. > > > > Arm architectures, however, never had a default machine type > > associated with them, so if no machine type is requested by the > > user we should just go through the usual path of picking the > > first one reported by the 'query-machines' QMP command instead > > of using integratorcp straight away. > > NACK, this is incorrect and breaking historical libvirt behaviour. > > When QEMU does not report any default machine type for an > architecture, libvirt would pick the first machine type > it found. This is why "integratorcp" must be listed here. I suspected as much after initially discussing the issue, hence why I CC'd you when posting. Looks like that was a good call! :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
