On Mon, Nov 26, 2018 at 01:21:32PM +0100, Andrea Bolognani wrote: > Commit 26cfb1a3cd39 introduced a list of preferred machine types, > which are meant to reflect QEMU's per-architecture historical > defaults and shield libvirt users from any changes in that area. > > Arm architectures, however, never had a default machine type > associated with them, so if no machine type is requested by the > user we should just go through the usual path of picking the > first one reported by the 'query-machines' QMP command instead > of using integratorcp straight away. > > Reported-by: Kashyap Chamarthy <kchamart@xxxxxxxxxx> > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > --- > src/qemu/qemu_capabilities.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks. FWIW: Reviewed-by Kashyap Chamarthy <kchamart@xxxxxxxxxx> > + NULL, /* VIR_ARCH_AARCH64 (no default machine type) */ > "axis-dev88", /* VIR_ARCH_CRIS */ > "pc", /* VIR_ARCH_I686 */ > NULL, /* VIR_ARCH_ITANIUM (doesn't exist in QEMU any more) */ > -- > 2.19.1 > -- /kashyap -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
