Re: [PATCH 3/3] conf: Perform error checking in virDomainDeviceInfoFormat()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 16, 2018 at 05:21:31PM +0100, Andrea Bolognani wrote:
> virXMLFormatElement() might fail, but we were not checking
> its return value.
> 
> Fixing this requires us to change virDomainDeviceInfoFormat()
> so that it can report an error back to the caller.
> 
> Introduced-by: 0d6b87335c00451b0923ecc91d617f71e4135bf8
> Spotted-by: Coverity
> Reported-by: John Ferlan <jferlan@xxxxxxxxxx>
> Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> ---
>  src/conf/domain_conf.c | 97 ++++++++++++++++++++++++++++--------------
>  1 file changed, 66 insertions(+), 31 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux