Andrea Bolognani <abologna@xxxxxxxxxx> writes: > On Wed, 2018-11-14 at 17:27 +0100, Vitaly Kuznetsov wrote: >> Qemu 3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows > > s/Qemu/QEMU/ > > Better than in v1 but not quite perfect yet ;) > > [...] >> + <change> >> + <summary> >> + qemu: Add Hyper-V PV IPI support >> + </summary> >> + <description> >> + The QEMU driver now has support for Hyper-V PV IPI enlightenment >> + for Windows guests. >> + </description> >> + </change> > > Okay, not your fault at all, just something that I failed to > communicate properly: updates to the release notes are supposed to > always go in their own commit. The rationale for that is making it > easy for downstreams to cherry-pick the code changes without having > to worry about conflicts in the documentation. > > Additionally, and again I'm at fault for not communicating it > adequately, I kinda expected to have a single entry in the release > notes covering both changes. Does that sound reasonable? > > Since everything else looks good and I'd rather not have you go > through more trouble than you already have, if you're okay with it > I can just drop this hunk from the patch, slap a > > Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> > > on it and push it; you can then re-post the release note update > as a separate follow up patch. Let me know if that works for you. No problem at all, I can do v3 fixing stuff like Qemu/QEMU, separate docs/news.xml hunks into their own patch (squashing together as a single <change>). Thanks for the review! -- Vitaly -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
