On Wed, 2018-11-14 at 17:27 +0100, Vitaly Kuznetsov wrote: > Support Hyper-V PV IPI enlightenment in domain config. Qemu support will s/Qemu/QEMU/ > be implemented in the next patch, adding interim VIR_DOMAIN_HYPERV_IPI cases > to src/qemu/* for now. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx> > --- > docs/formatdomain.html.in | 7 +++++++ > docs/schemas/domaincommon.rng | 5 +++++ > src/conf/domain_conf.c | 7 ++++++- > src/conf/domain_conf.h | 1 + > src/cpu/cpu_x86.c | 3 +++ > src/cpu/cpu_x86_data.h | 1 + > src/qemu/qemu_command.c | 1 + > src/qemu/qemu_parse_command.c | 1 + > src/qemu/qemu_process.c | 1 + > 9 files changed, 26 insertions(+), 1 deletion(-) So, personally I don't feel like splitting the patch into two really improves the situation - actually the opposite, since now as you mention in the commit message you have to go out of your way to add placeholders only to remove them in the next commit. But it's really not a big deal either way, so you can leave it as-is and, with the commit message fixed, still get a Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx> -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
