Igor Mammedov <imammedo@xxxxxxxxxx> writes: > On Fri, 19 Oct 2018 17:23:21 -0300 > Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote: > >> On Fri, Oct 19, 2018 at 09:53:45PM +0200, Igor Mammedov wrote: >> > On Fri, 19 Oct 2018 15:44:08 -0300 >> > Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote: >> > >> > > On Fri, Oct 19, 2018 at 03:12:31PM +0100, Peter Maydell wrote: >> > > > On 18 October 2018 at 21:03, Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote: >> > > > > The following changes since commit 09558375a634e17cea6cfbfec883ac2376d2dc7f: >> > > > > >> > > > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20181016-1' into staging (2018-10-16 17:42:56 +0100) >> > > > > >> > > > > are available in the Git repository at: >> > > > > >> > > > > git://github.com/ehabkost/qemu.git tags/machine-next-pull-request >> > > > > >> > > > > for you to fetch changes up to 6d8e1bcc7dd5e819ce81e6a87fffe23e39c700cc: >> > > > > >> > > > > numa: Clean up error reporting in parse_numa() (2018-10-17 16:33:40 -0300) >> > > > > >> > > > > ---------------------------------------------------------------- >> > > > > Machine queue, 2018-10-18 >> > > > > >> > > > > * sysbus init/realize cleanups >> > > > > (Cédric Le Goater, Philippe Mathieu-Daudé) >> > > > > * memory-device refactoring (David Hildenbrand) >> > > > > * -smp: deprecate incorrect CPUs topology (Igor Mammedov) >> > > > > * -numa parsing cleanups (Markus Armbruster) >> > > > > * Fix hostmem-file memory leak (Zhang Yi) >> > > > > * Typo fix (Li Qiang) >> > > > > >> > > > > ---------------------------------------------------------------- >> > > > > >> > > > >> > > > Hi. This had some problems in merge testing, I'm afraid: >> > > > >> > > > On aarch64 host, warnings running tests/cpu-plug-test for i386 and s390 targets: >> > > > >> > > > TEST: tests/cpu-plug-test... (pid=12602) >> > > > /i386/cpu-plug/pc-i440fx-3.0/cpu-add/1x3x2&maxcpus=12: >> > > > qemu-system-i386: warning: Invalid CPU topology deprecated: sockets >> > > > (1) * cores (3) * threads (2) != maxcpus (12) >> > > [...] >> > > > >> > > > (plus similar ppc64, x86_64 targets) >> > > >> > > Ouch. Apologies. >> > > >> > > Can we please do something make sure "make check" will fail on >> > > these cases? I'd like to be able to trust CI systems like >> > > travis-ci. >> > > >> > >> > we probably don't want make check fail on warning. >> >> I disagree. If a warning is blocking a pull request from being >> merged, it must make CI systems fail too. Otherwise we're >> defeating the purpose of CI systems. > > When we deprecate options we are bound to trigger warning which are not errors > and are meant to be there until deprecated options are removed/tested by make check. > So what would you suggest to do wrt tests that use deprecated features, > drop testing for it? We commonly suppress the warning when testing. Search for 'if (qtest_enabled())'. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
