On 10/19/2018 10:03 AM, Erik Skultety wrote: > On Fri, Oct 05, 2018 at 01:48:06PM +0200, Ján Tomko wrote: >> Recent patches added indentation checks that discovered some cosmetic >> issues at the cost of making this check last as long as the rest of >> syntax-check combined on my system. Also, they're moving closer >> to us implementing yet another C parser (docs/apibuild.py being the >> other one). >> >> Revert the following commits: >> commit 11e1f11dd34f2688169c63c13ea8d99a64724369 >> syntax-check: Check for incorrect indentation in function body >> commit 2585a79e32e8b0d994ab35fd7c641eb9b96632e3 >> build-aux:check-spacing: Introduce a new rule to check misaligned stuff in parenthesises >> commit a033182f042a07ffbd4b9a50418670778ceddbf3 >> build-aux:check-spacing: Add wrapper function of CheckCurlyBrackets >> commit 6225626b6f0a4817d1f17de0bc5200c5d7986a3e >> build-aux:check-spacing: Add wrapper function of CheckWhiteSpaces >> commit c3875129d9bd094ffe90d54fbec86624ae88c40b >> build-aux:check-spacing: Add wrapper function of KillComments >> commit e995904c5691be3c21f4c6dbc1f067fe0c8e8515 >> build-aux:check-spacing: Add wrapper function of CheckFunctionBody >> commit 11e1f11dd34f2688169c63c13ea8d99a64724369 >> syntax-check: Check for incorrect indentation in function body >> >> This brings the speed of the script to a tolerable level and lets it >> focus on the more visible issues. >> >> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx> > Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx> > So what alternative do we have? Obviously, we fail at honoring our formatting rules. Having a check that would fail at `synax-check' time would help us. Okay, implementing new C parser might not be the best solution, but it's at least something. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
