On 10/18/18 3:32 AM, Jie Wang wrote: > From fca1732c0e1f691fb25c614349d5486bbc73a109 Mon Sep 17 00:00:00 2001 > From: Jie Wang <wangjie88@xxxxxxxxxx> > Date: Wed, 17 Oct 2018 22:55:51 +0800 > Subject: [PATCH] qemu: Fix IOThread pids lost after qemuProcessReconnect Removed whatever ^^^^this was (and it was in both patches you posted, this just happens to be the second one). > > IOThread pids info will lost after libvirtd restart, then > if we call pinIOThread, sched_setaffinity will be called with > pid 0, not IOThread pid. So pinIOThread cannot work normally. > > Signed-off-by: Jie Wang <wangjie88.huawei.com> > --- > src/qemu/qemu_process.c | 3 +++ > 1 file changed, 3 insertions(+) > Very strange looked through history to see if somehow some patch removed a call during *Reconnect, but found nothing (of course). I cannot recall why in the original commit 9bef96ec502 that this wasn't added. It was added in *Start (which eventually because *Launch) and *Attach, but not *Reconnect. Oh well, good catch. Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> (and pushed) Tks, John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
