On Thu, Oct 18, 2018 at 02:26:38PM +0200, Michal Privoznik wrote:
These are not pushed. I'll wait couple of moments if there is somebody who has opinion. If not I will push them.
Except the libvirt-snmp internals this looks good. Few nits posted for particular patches, really just nits. It's a nice clean-up, it definitely makes sense to drop support for too old libvirt IMHO. If you want to make the (+)/(-) ratio even smaller you can reorganize some ofthe patches about error printing and formatting as you are adding some support, then moving it, then putting it in another function and so on. But I don't think the readability is too much impacted by that. It would just make for a nicer git history and even more awesome ratio ;) Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>
Attachment:
signature.asc
Description: Digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
