[PATCH 2/2] Revert "qemu: Forbid pinning vCPUs for TCG domain"

[Daniel P. Berrangé <berrange@xxxxxxxxxx>]

This reverts commit 8b035c84d8a7362a87a95e6114b8e7f959685ed9.

The MTTCG impl in QEMU does allow pinning vCPUs.

When the guest is running we already check if pinning is
possible in the qemuDomainPinVcpuLive method, so this
check was adding no benefit.

When the guest is not running, we cannot know whether the
subsequent launch will use MTTCG or TCG, so we must allow
the pinning request. If the guest does use TCG on the next
launch it will fail, but this is no worse than if the user
had done a virDomainDefineXML with an XML doc specifying
vCPU pinning.

Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
---
 src/qemu/qemu_driver.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index a52e2495d5..981db01059 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -5111,13 +5111,6 @@ qemuDomainPinVcpuFlags(virDomainPtr dom,
     if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0)
         goto endjob;
 
-    if ((def && def->virtType == VIR_DOMAIN_VIRT_QEMU) ||
-        (persistentDef && persistentDef->virtType == VIR_DOMAIN_VIRT_QEMU)) {
-        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
-                       _("Virt type 'qemu' does not support vCPU pinning"));
-        goto endjob;
-    }
-
     if (persistentDef &&
         !(vcpuinfo = virDomainDefGetVcpu(persistentDef, vcpu))) {
         virReportError(VIR_ERR_INVALID_ARG,
-- 
2.17.2

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list