Re: [PATCH v2 2/2] add docs for interleave nodeset='all'

[John Ferlan <jferlan@xxxxxxxxxx>]

On 9/29/18 6:58 AM, Peng Hao wrote:
> Signed-off-by: Peng Hao <peng.hao2@xxxxxxxxxx>
> ---
>  docs/formatdomain.html.in | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

This should have been merged with patch 1

> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index 1f12ab5..9aca921 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -1242,6 +1242,7 @@
>    ...
>    &lt;numatune&gt;
>      &lt;memory mode="strict" nodeset="1-4,^3"/&gt;
> +    &lt;memory mode="interleave" nodeset="all"/&gt;
>      &lt;memnode cellid="0" mode="strict" nodeset="1"/&gt;
>      &lt;memnode cellid="2" mode="preferred" nodeset="2"/&gt;
>    &lt;/numatune&gt;
> @@ -1264,7 +1265,8 @@
>          attributes. Attribute <code>mode</code> is either 'interleave',
>          'strict', or 'preferred', defaults to 'strict'. Attribute
>          <code>nodeset</code> specifies the NUMA nodes, using the same syntax as
> -        attribute <code>cpuset</code> of element <code>vcpu</code>. Attribute
> +        attribute <code>cpuset</code> of element <code>vcpu</code>.For 'interleave'

s/.F/. F/

> +        mode, 'nodeset' can be set to 'all' which stands for all nodes in host. Attribute

Like noted before I think perhaps all would be useful for other
{cpu|node}set values.

Also when you add a new feature, then you need to note a <span
class='since'>Since 4.9.0</span> on the new attribute option "all". (or
whatever version this would be added).

John

>          <code>placement</code> (<span class='since'>since 0.9.12</span>) can be
>          used to indicate the memory placement mode for domain process, its value
>          can be either "static" or "auto", defaults to <code>placement</code> of
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list